Skip to content

[Kocal/SymfonyAppPack] Add recipe#1936

Merged
symfony-recipes-bot merged 2 commits intosymfony:mainfrom
Kocal:kocal/symfony-app-pack
Feb 10, 2026
Merged

[Kocal/SymfonyAppPack] Add recipe#1936
symfony-recipes-bot merged 2 commits intosymfony:mainfrom
Kocal:kocal/symfony-app-pack

Conversation

@Kocal
Copy link
Member

@Kocal Kocal commented Feb 6, 2026

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 6, 2026 07:17
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1936/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1936/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'kocal/symfony-app-pack:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled February 6, 2026 07:19

Head branch was pushed to by a user without write access

@Kocal Kocal force-pushed the kocal/symfony-app-pack branch from f15328a to c639f06 Compare February 6, 2026 07:19
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 6, 2026 07:20
auto-merge was automatically disabled February 6, 2026 07:22

Head branch was pushed to by a user without write access

@Kocal Kocal force-pushed the kocal/symfony-app-pack branch from c639f06 to d7bdad6 Compare February 6, 2026 07:22
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 6, 2026 07:22
auto-merge was automatically disabled February 6, 2026 07:27

Head branch was pushed to by a user without write access

@Kocal Kocal force-pushed the kocal/symfony-app-pack branch from d7bdad6 to 10e873a Compare February 6, 2026 07:27
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 6, 2026 07:27
@Kocal
Copy link
Member Author

Kocal commented Feb 6, 2026

I'm not sure to understand why it's failing:

 - Configuring kocal/symfony-app-pack (>=1.0): From github.com/symfony/recipes-contrib:main
    Copying files from recipe
      Created "./.github/dependabot.yaml"
      Created "./.github/workflows/ci.yaml"
      Created "./tools/.gitignore"
      Created "./tools/make/git.mk"
      Created "./tools/make/help.mk"
      Created "./tools/make/os.mk"
      Created "./tools/make/text.mk"
      Created "./tools/phpstan/console-application.php"
      Created "./tools/phpstan/object-manager.php"
      Created "./tools/phpstan/symfony-configuration.php"
      Created "./.twig-cs-fixer.php"
      Created "./ecs.php"

In CopyFromRecipeConfigurator.php line 88:
                                  
  [ErrorException]                
  Undefined array key "Makefile"  
                                  

Exception trace:
  at /Users/kocal/workspace/kocal/my-super-app/vendor/symfony/flex/src/Configurator/CopyFromRecipeConfigurator.php:88
 Composer\Util\ErrorHandler::handle() at /Users/kocal/workspace/kocal/my-super-app/vendor/symfony/flex/src/Configurator/CopyFromRecipeConfigurator.php:88
 Symfony\Flex\Configurator\CopyFromRecipeConfigurator->copyFiles() at /Users/kocal/workspace/kocal/my-super-app/vendor/symfony/flex/src/Configurator/CopyFromRecipeConfigurator.php:28
 Symfony\Flex\Configurator\CopyFromRecipeConfigurator->configure() at /Users/kocal/workspace/kocal/my-super-app/vendor/symfony/flex/src/Configurator.php:61
 Symfony\Flex\Configurator->install() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/src/Composer/Plugin/PluginManager.php(281) : eval()'d code:441
 Symfony\Flex\Flex_composer_tmp0->install() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/src/Composer/Plugin/PluginManager.php(281) : eval()'d code:313
 Symfony\Flex\Flex_composer_tmp0->update() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:232
 Composer\EventDispatcher\EventDispatcher->doDispatch() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:142
 Composer\EventDispatcher\EventDispatcher->dispatchScript() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/src/Composer/Installer.php:414
 Composer\Installer->run() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/src/Composer/Command/RequireCommand.php:494
 Composer\Command\RequireCommand->doUpdate() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/src/Composer/Command/RequireCommand.php:336
 Composer\Command\RequireCommand->execute() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/vendor/symfony/console/Command/Command.php:298
 Symfony\Component\Console\Command\Command->run() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/vendor/symfony/console/Application.php:1040
 Symfony\Component\Console\Application->doRunCommand() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/vendor/symfony/console/Application.php:301
 Symfony\Component\Console\Application->doRun() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/src/Composer/Console/Application.php:418
 Composer\Console\Application->doRun() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/src/Composer/Console/Application.php:138
 Composer\Console\Application->run() at phar:///opt/homebrew/Cellar/composer/2.9.2/bin/composer/bin/composer:112
 require() at /opt/homebrew/Cellar/composer/2.9.2/bin/composer:29

EDIT: I think it conflicts with the MakefileConfigurator in some way 🤔
EDIT 2: Indeed, from https://github.com/symfony/recipes#makefile-configurator:

Adds new tasks to the Makefile file stored in the root of the Symfony project. Unlike other configurators, there is no specific entry in the manifest file. Define tasks by creating a Makefile file at the root of the recipe directory (a PHP_EOL character is added after each line).

A new Makefile (with some boilerplate) is created when the recipe contains a Makefile. TIL!

auto-merge was automatically disabled February 6, 2026 07:52

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 6, 2026 07:53
auto-merge was automatically disabled February 6, 2026 07:56

Head branch was pushed to by a user without write access

@Kocal Kocal force-pushed the kocal/symfony-app-pack branch from 7935072 to 1c93f8a Compare February 6, 2026 07:56
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 6, 2026 07:56
@Kocal
Copy link
Member Author

Kocal commented Feb 6, 2026

The following error will be fixed when #1934 will be merged:

Script cache:clear returned with error code 1
!!  
!!  In ArrayNode.php line 213:
!!                                                                                 
!!    The child config "apps_version" under "kocal_oxc" must be configured: The v  
!!    ersion of git tag "apps_v*" to download. For example, git tag "apps_v1.43.0  
!!    " corresponds to version "1.43.0".                                           
!!                                                                                 
!!  
!!  
Script @auto-scripts was called via post-update-cmd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if Flex provides a Makefile boilerplate with a help target, this one is better to me because it makes it possible to group tasks under sections:

➜  my-super-app git:(main) ✗ make help

Usage: make [command]   

Help:   
  help This help

Commands:
  install Install everything needed to start the project
  start   Start the environment
  stop    Stop the environment
  delete  Stop and delete the environment and project data (database, logs, etc.)

App:
  app.install Install the application
  app.update  Install the application (alias to "make app.install")

Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kocal Hi, a minor comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Makefile is not part of manifest, please either add to manifest or remove from PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Makefile can not be part of the manifest, please see #1936 (comment)

auto-merge was automatically disabled February 10, 2026 22:32

Head branch was pushed to by a user without write access

@Kocal Kocal force-pushed the kocal/symfony-app-pack branch from 1c93f8a to 243ac8e Compare February 10, 2026 22:32
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 10, 2026 22:32
@symfony-recipes-bot symfony-recipes-bot merged commit cdc5b03 into symfony:main Feb 10, 2026
1 of 2 checks passed
@Kocal Kocal deleted the kocal/symfony-app-pack branch February 11, 2026 06:20
@Kocal
Copy link
Member Author

Kocal commented Feb 11, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants